Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove language suffixes from vocabulary ids in example config #607

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

osma
Copy link
Member

@osma osma commented Aug 12, 2022

This little PR does two things to the example configuration file projects.cfg.dist:

  • strip the language prefixes (e.g. yso-en becomes yso) from vocabulary IDs, as it's now unnecessary to use language-specific vocabularies after the introduction of multilingual vocabularies (PR Multilingual vocabularies #559)
  • set the vocabulary for some ensemble projects that were missing the vocab setting

@osma osma added this to the 0.59 milestone Aug 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #607 (95de774) into master (391ed7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          86       86           
  Lines        5673     5673           
=======================================
  Hits         5648     5648           
  Misses         25       25           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@osma osma changed the title Remove language suffixes from vocabulary ids, now unnecessary Remove language suffixes from vocabulary ids in example config Aug 12, 2022
@osma osma merged commit 191b25a into master Aug 12, 2022
@osma osma deleted the fix-example-config-file branch August 12, 2022 09:40
@osma osma self-assigned this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant