Upgrade Simplemma to version 0.7 #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
==========================================
- Coverage 99.48% 99.48% -0.01%
==========================================
Files 86 86
Lines 5645 5636 -9
==========================================
- Hits 5616 5607 -9
Misses 29 29
Continue to review full report at Codecov.
|
|
Test results added to the table taken from #591:
The results are essentially unchanged (runs completed slightly faster) and no problems were encountered. I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Simplemma dependency (which is used in the simplemma analyzer, added in #591) from version 0.6 to 0.7.
Simplemma now does the loading of language data internally, so the calling code could be simplified even more from what it was. There is no need for the
__getstate__trick so that was deleted too.Related to this comment
Note that I haven't tested this for real (yet), just verified that the tests pass, so keeping it as a draft PR for now.