Avoid coverage 6.3 as it causes some tests to hang #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 95.05% 99.46% +4.41%
==========================================
Files 82 82
Lines 5356 5444 +88
==========================================
+ Hits 5091 5415 +324
+ Misses 265 29 -236
Continue to review full report at Codecov.
|
juhoinkinen
added a commit
that referenced
this pull request
Jan 4, 2023
Pinning was necessary due to issue #565, coverage v6.4 should have the underlying problem fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a stopgap fix to avoid CI jobs getting stuck. This seems to be caused by changes in Coverage 6.3 - see nedbat/coveragepy#1310
A better fix may be needed later but let's see what happens on the Coverage side first. Until then, this change should work around the problem.
Fixes #564