Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect treatment of az:// URL's in CLI #283

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

michael-nml
Copy link
Collaborator

Fsspec supports both az:// and abfs:// prefixes for azure blob storage. We should also accept both to avoid confusion.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b072ab2) 79.43% compared to head (1b43138) 79.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          74       74           
  Lines        6205     6205           
  Branches      982      982           
=======================================
  Hits         4929     4929           
  Misses       1022     1022           
  Partials      254      254           
Impacted Files Coverage Δ
nannyml/io/base.py 51.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nnansters nnansters merged commit 71b7188 into main Apr 18, 2023
@nnansters nnansters deleted the fix/cli-az-url branch June 28, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants