Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous NaN result from some (regression realized) performance calculations #279

Closed
nikml opened this issue Apr 7, 2023 · 4 comments
Closed

Erroneous NaN result from some (regression realized) performance calculations #279

nikml opened this issue Apr 7, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@nikml
Copy link
Contributor

nikml commented Apr 7, 2023

Describe the bug
While working on an internal dataset the last chunk of data produced a NaN result for mse realized performance calculation.
Calculating the performance manually resulted in a valid performance value number.

The culprit appears to be this line of code. This check and it's treatment shouldn't be there.

We should also check if this behavior happens on other performance metrics.
@nikml nikml added bug Something isn't working triage Needs to be assessed labels Apr 7, 2023
nnansters added a commit that referenced this issue Apr 7, 2023
@nnansters
Fix: remove erroneous checks on realized regression metric calculatio…
b072ab2 
…ns. Partial fix for #279

Signed-off-by: Niels Nuyttens <niels@nannyml.com>
@nnansters nnansters removed the triage Needs to be assessed label Apr 7, 2023
@nnansters
Copy link
Contributor

Pushed a quick fix for regression right now. We'll have to comb through the other metrics for a quick check if the same issue applies there.

@stale
Copy link

stale bot commented Jun 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 6, 2023
@nnansters nnansters removed the stale label Jun 7, 2023
@nnansters nnansters removed their assignment Jun 7, 2023
@michael-nml michael-nml mentioned this issue Jun 9, 2023
Merged
@stale
Copy link

stale bot commented Aug 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 6, 2023
@nnansters nnansters removed the stale label Aug 6, 2023
@stale
Copy link

stale bot commented Oct 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 5, 2023
@stale stale bot closed this as completed Oct 12, 2023
@nnansters nnansters removed the stale label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikml @nnansters