Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

238 add option to univariatedriftcalculator to explicitly mark columns as categorical #239

Conversation

nnansters
Copy link
Contributor

No description provided.

nnansters and others added 2 commits February 24, 2023 02:02
Signed-off-by: Niels Nuyttens <niels@nannyml.com>
- revert car loan dataset changes (targets and predictions are ints again)
- Use new 'treat_as_categorical' parameter in docs

Signed-off-by: Niels Nuyttens <niels@nannyml.com>
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 80.14% // Head: 80.18% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (9cf09d8) compared to base (67cf03f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   80.14%   80.18%   +0.04%     
==========================================
  Files          73       73              
  Lines        6105     6118      +13     
  Branches      924      930       +6     
==========================================
+ Hits         4893     4906      +13     
  Misses        979      979              
  Partials      233      233              
Impacted Files Coverage Δ
nannyml/drift/univariate/calculator.py 100.00% <ø> (ø)
nannyml/plots/__init__.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nnansters nnansters marked this pull request as ready for review February 24, 2023 02:08
@nnansters nnansters requested a review from nikml as a code owner February 24, 2023 02:08
@nnansters nnansters merged commit 636ebcb into main Feb 24, 2023
@nnansters nnansters deleted the 238-add-option-to-univariatedriftcalculator-to-explicitly-mark-columns-as-categorical branch February 26, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to UnivariateDriftCalculator to explicitly mark columns as categorical
2 participants