Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified cm cbpe #191

Merged
merged 26 commits into from
Feb 8, 2023
Merged

Unified cm cbpe #191

merged 26 commits into from
Feb 8, 2023

Conversation

cartgr
Copy link
Contributor

@cartgr cartgr commented Feb 1, 2023

Added "confusion_matrix" metric to CBPE. Still need to clean up and add tests and docs.

cartgr added 16 commits January 26, 2023 20:35
@cartgr
EOD rough state save
928c954
@cartgr
clean up commit
45e8421
@cartgr
Merge branch 'NannyML:main' into unified_cm_cbpe
f9a76e7
@cartgr
impl alert thresh and realized
1c6c907
@cartgr
Merge branch 'unified_cm_cbpe' of https://github.com/cartgr/nannyml i…
fe5ad82 
…nto unified_cm_cbpe
@cartgr
implemented estimate and rest of get_info funcs
dfc1a7d
@cartgr
Working implementation of confusion_matrix metric
aa0ba85
@cartgr
cbpe binary and multiclass refactor working
a553cd8
@cartgr
Merge branch 'NannyML:main' into unified_cm_cbpe
077bf7d
@cartgr
updated filtering for confusion matrix metric
5872067
@cartgr
Wrote tests, need to update testing file
cf3ae64
@cartgr
adjusted filtering to work with confusion_matrix metric
20e215a
@cartgr
Update filtering exception
b6af356
@cartgr
tests written. Working to resolve poetry issues
5828e54
@cartgr
updated testing files
439fb5d
@cartgr
All tests passing locally :')
efb0466
@codecov
Copy link

codecov bot commented Feb 3, 2023 •
edited
Loading

Codecov Report

Base: 77.68% // Head: 79.22% // Increases project coverage by +1.54% 🎉

Coverage data is based on head (c01bccd) compared to base (996bd9f).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   77.68%   79.22%   +1.54%     
==========================================
  Files          73       73              
  Lines        5278     5751     +473     
  Branches      817      891      +74     
==========================================
+ Hits         4100     4556     +456     
- Misses        952      957       +5     
- Partials      226      238      +12
Impacted Files Coverage Δ
nannyml/drift/ranker.py 93.40% <ø> (+0.14%) ⬆️
nannyml/io/db/mappers.py 90.65% <ø> (ø)
...ml/performance_estimation/confidence_based/cbpe.py 87.09% <ø> (-1.66%) ⬇️
...performance_estimation/confidence_based/metrics.py 96.38% <ø> (+0.61%) ⬆️
...performance_estimation/confidence_based/results.py 96.77% <ø> (-3.23%) ⬇️
nannyml/plots/blueprints/comparisons.py 83.73% <ø> (ø)
nannyml/plots/blueprints/metrics.py 82.60% <ø> (ø)
nannyml/plots/components/stacked_bar_plot.py 84.00% <ø> (ø)
nannyml/sampling_error/binary_classification.py 96.80% <ø> (-3.21%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cartgr cartgr marked this pull request as ready for review February 6, 2023 05:33
cartgr and others added 5 commits February 6, 2023 04:12
@cartgr
Removing scratch files
28edb68
@nnansters
Merging with main
89ab0b2 
Signed-off-by: Niels Nuyttens <niels@nannyml.com>
@nnansters
Refactor "components" for CBPE metrics
7256476 
Signed-off-by: Niels Nuyttens <niels@nannyml.com>
@nnansters
Merge branch 'main' into unified_cm_cbpe
0e73c91 
# Conflicts:
#	docs/_static/tutorial-perf-est-regression.svg
#	docs/_static/tutorials/performance_calculation/binary/tutorial-performance-calculation-binary.svg
@nnansters
Fix broken tests
c01bccd 
Signed-off-by: Niels Nuyttens <niels@nannyml.com>
@nnansters nnansters merged commit e821cf3 into NannyML:main Feb 8, 2023
@cartgr cartgr deleted the unified_cm_cbpe branch February 9, 2023 20:16
@cartgr cartgr restored the unified_cm_cbpe branch February 9, 2023 20:16
@cartgr cartgr deleted the unified_cm_cbpe branch March 8, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnansters nnansters Awaiting requested review from nnansters nnansters is a code owner

@nikml nikml Awaiting requested review from nikml nikml is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cartgr @nnansters