Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markers flickering in RViz #120

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

mintar
Copy link
Contributor

@mintar mintar commented May 7, 2020

Fixes #119 .

This pull request is not tested yet because I don't have access to the hardware at the moment. Please test before merging.

@mintar mintar mentioned this pull request May 7, 2020
@mintar mintar marked this pull request as draft May 7, 2020 10:18
@mintar mintar changed the title [WIP] Fix markers flickering in RViz Fix markers flickering in RViz May 7, 2020
@Tingcccc
Copy link

Tingcccc commented May 7, 2020

Change marker.action = Marker.DELETEALL to Marker.DELETE that can fix the flickering problem in RViz.

@mintar
Copy link
Contributor Author

mintar commented May 7, 2020

Change marker.action = Marker.DELETEALL to Marker.DELETE that can fix the flickering problem in RViz.

Nope, that doesn't work. See my comment on #119.

@TontonTremblay
Copy link
Collaborator

I also do not have access to testing material. Thank you for quickly answering our friend on this! I will merge once it is tested.

@Tingcccc
Copy link

I have an additional question, how do I display the 3D cube and the bounding box on the same image?
Thank you.

@mintar
Copy link
Contributor Author

mintar commented May 18, 2020

I have an additional question, how do I display the 3D cube and the bounding box on the same image?

Answered at #119.

@mintar mintar force-pushed the fix_marker_flickering branch from b266269 to 33d771e Compare May 18, 2020 14:42
@mintar mintar marked this pull request as ready for review July 1, 2020 12:21
@mintar
Copy link
Contributor Author

mintar commented Jul 1, 2020

I have just successfully tested this PR, and it is ready for merging.

@TontonTremblay TontonTremblay merged commit bdecff7 into NVlabs:master Sep 22, 2020
@mintar mintar deleted the fix_marker_flickering branch October 14, 2020 13:27
athnzc pushed a commit to athnzc/dope_fork that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROS visualization in RViz
3 participants