-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pycga] python bindings for cudapoa #38
Merged
vellamike
merged 27 commits into
NVIDIA-Genomics-Research:dev-v0.2.0
from
tijyojwad:jdaw/add-cudapoa-python-binding
Aug 5, 2019
Merged
[pycga] python bindings for cudapoa #38
vellamike
merged 27 commits into
NVIDIA-Genomics-Research:dev-v0.2.0
from
tijyojwad:jdaw/add-cudapoa-python-binding
Aug 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tijyojwad
commented
Jul 17, 2019
- Setup build for python ingestion
- Setup cython bindings for CUDAPOA and cuda
- Install cython built libraries into python
tijyojwad
changed the title
[pycga] python bindings for cudapoa
WIP: [pycga] python bindings for cudapoa
Jul 17, 2019
tijyojwad
force-pushed
the
jdaw/add-cudapoa-python-binding
branch
2 times, most recently
from
July 23, 2019 21:06
526e066
to
992bcb3
Compare
tijyojwad
changed the title
WIP: [pycga] python bindings for cudapoa
[pycga] python bindings for cudapoa
Jul 23, 2019
tijyojwad
commented
Jul 23, 2019
tijyojwad
force-pushed
the
jdaw/add-cudapoa-python-binding
branch
from
July 24, 2019 16:03
3d86cc2
to
11e7224
Compare
Conflicts: cudapoa/benchmarks/multi-batch/multi_batch.hpp cudapoa/benchmarks/single-batch/single_batch.hpp cudapoa/include/claragenomics/cudapoa/batch.hpp cudapoa/src/batch.cpp cudapoa/src/cudapoa_batch.cpp cudapoa/src/cudapoa_batch.hpp cudapoa/tests/Test_CudapoaBatch.cpp cudapoa/tests/Test_CudapoaGenerateMSA2.cpp pyclaragenomics/claragenomics/test/test_wrappers.py pyclaragenomics/requirements.txt
Conflicts: cudapoa/benchmarks/multi-batch/multi_batch.hpp cudapoa/benchmarks/single-batch/single_batch.hpp cudapoa/src/batch.cpp cudapoa/src/cudapoa_batch.hpp cudapoa/tests/Test_CudapoaBatch.cpp cudapoa/tests/Test_CudapoaGenerateMSA2.cpp
tijyojwad
force-pushed
the
jdaw/add-cudapoa-python-binding
branch
from
August 1, 2019 19:07
a5bab97
to
38c6d7f
Compare
vellamike
suggested changes
Aug 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Once the review comments are addressed could you add a quickstart to the pyclaragenomics readme showing how the consensus can be computed?
rerun tests |
vellamike
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.