Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pycga] python bindings for cudapoa #38

Conversation

tijyojwad
Copy link
Contributor

  1. Setup build for python ingestion
  2. Setup cython bindings for CUDAPOA and cuda
  3. Install cython built libraries into python

@tijyojwad tijyojwad self-assigned this Jul 17, 2019
@tijyojwad tijyojwad changed the title [pycga] python bindings for cudapoa WIP: [pycga] python bindings for cudapoa Jul 17, 2019
@tijyojwad tijyojwad force-pushed the jdaw/add-cudapoa-python-binding branch 2 times, most recently from 526e066 to 992bcb3 Compare July 23, 2019 21:06
@tijyojwad tijyojwad changed the title WIP: [pycga] python bindings for cudapoa [pycga] python bindings for cudapoa Jul 23, 2019
@tijyojwad tijyojwad requested review from vellamike and jisraeli July 23, 2019 22:33
@tijyojwad tijyojwad assigned vellamike and jisraeli and unassigned tijyojwad Jul 23, 2019
@tijyojwad tijyojwad force-pushed the jdaw/add-cudapoa-python-binding branch from 3d86cc2 to 11e7224 Compare July 24, 2019 16:03
 Conflicts:
	cudapoa/benchmarks/multi-batch/multi_batch.hpp
	cudapoa/benchmarks/single-batch/single_batch.hpp
	cudapoa/include/claragenomics/cudapoa/batch.hpp
	cudapoa/src/batch.cpp
	cudapoa/src/cudapoa_batch.cpp
	cudapoa/src/cudapoa_batch.hpp
	cudapoa/tests/Test_CudapoaBatch.cpp
	cudapoa/tests/Test_CudapoaGenerateMSA2.cpp
	pyclaragenomics/claragenomics/test/test_wrappers.py
	pyclaragenomics/requirements.txt
Joyjit Daw added 2 commits August 1, 2019 11:49
 Conflicts:
	cudapoa/benchmarks/multi-batch/multi_batch.hpp
	cudapoa/benchmarks/single-batch/single_batch.hpp
	cudapoa/src/batch.cpp
	cudapoa/src/cudapoa_batch.hpp
	cudapoa/tests/Test_CudapoaBatch.cpp
	cudapoa/tests/Test_CudapoaGenerateMSA2.cpp
@tijyojwad tijyojwad force-pushed the jdaw/add-cudapoa-python-binding branch from a5bab97 to 38c6d7f Compare August 1, 2019 19:07
Copy link
Contributor

@vellamike vellamike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Once the review comments are addressed could you add a quickstart to the pyclaragenomics readme showing how the consensus can be computed?

ci/common/test-pyclaragenomics.sh Outdated Show resolved Hide resolved
pyclaragenomics/test/test_cudapoa_bindings.py Outdated Show resolved Hide resolved
pyclaragenomics/claragenomics/bindings/cudapoa.pyx Outdated Show resolved Hide resolved
pyclaragenomics/test/test_cudapoa_bindings.py Outdated Show resolved Hide resolved
pyclaragenomics/test/test_cudapoa_bindings.py Outdated Show resolved Hide resolved
pyclaragenomics/claragenomics/bindings/cudapoa.pyx Outdated Show resolved Hide resolved
pyclaragenomics/test/test_cudapoa_bindings.py Outdated Show resolved Hide resolved
pyclaragenomics/test/test_cudapoa_bindings.py Show resolved Hide resolved
@tijyojwad tijyojwad requested a review from vellamike August 2, 2019 18:42
@tijyojwad
Copy link
Contributor Author

rerun tests

@vellamike vellamike merged commit 9e4c63a into NVIDIA-Genomics-Research:dev-v0.2.0 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants