Skip to content
This repository has been archived by the owner on Jan 7, 2025. It is now read-only.

Data plug-in walkthrough #1766

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

gheinrich
Copy link
Contributor

No description provided.

@TimZaman
Copy link
Contributor

LGTM

@TimZaman TimZaman requested review from xbkong and ethantang95 and removed request for xbkong August 14, 2017 16:50
In most cases this can be left empty.
In our case we are creating a shortcut to the `DataIngestion` member of file `data.py` so we can refer to it as `digitsDataPluginSunnybrook:DataIngestion` in `setup.py`.

### digitsDataPluginSunnybrook/data.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this section into a table?

Copy link
Contributor

@ethantang95 ethantang95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good also.

@ethantang95 ethantang95 merged commit c5ed49a into NVIDIA:master Aug 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants