Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 - update_atmos_model_dynamics, update_atmos_model_radiation, update_atmos_model-down #124

Merged
merged 36 commits into from
Jun 20, 2024

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Jun 12, 2024

In this PR, three coupler subroutines have been defined and used in coupler_main

  1. coupler_update_atmos_model_dynamics
  2. coupler_update_atmos_model_radiation
  3. coupler_update_atmos_model_down

The same coupler_update_atmos_model_radiation subroutine is called regardless of the value of do_concurrent_radiation. The chksum call in the this coupler subroutine is turned off when do_concurrent_radiation= .True.

Lastly, serial_radiation and concurrent_radiation clocks have been removed. One clock, radiation is used.

@mlee03 mlee03 marked this pull request as ready for review June 17, 2024 13:34
rem1776
rem1776 previously approved these changes Jun 20, 2024
Copy link
Member

@thomas-robinson thomas-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a few variables' documentation. Please update.

type(FmsTime_type), intent(in) :: Time_atmos !<Time_atmos FmsTime_type containing time in seconds
integer, intent(in) :: current_timestep !< current_timestep
type(coupler_clock_type), intent(inout) :: coupler_clocks !<coupler_clocks
type(coupler_chksum_type), intent(in) :: coupler_chksum_obj
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be documented

@rem1776 rem1776 merged commit 0524339 into NOAA-GFDL:main Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants