-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10 - update_atmos_model_dynamics, update_atmos_model_radiation, update_atmos_model-down #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coupler_update_atmos_model_radiation coupler_update_atmos_model_down coupler_flux_down_from_atmos
… atmos_model-flux_down
… tracer_driver_sfc_boundary_test
uramirez8707
approved these changes
Jun 20, 2024
rem1776
previously approved these changes
Jun 20, 2024
thomas-robinson
requested changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed a few variables' documentation. Please update.
full/full_coupler_mod.F90
Outdated
type(FmsTime_type), intent(in) :: Time_atmos !<Time_atmos FmsTime_type containing time in seconds | ||
integer, intent(in) :: current_timestep !< current_timestep | ||
type(coupler_clock_type), intent(inout) :: coupler_clocks !<coupler_clocks | ||
type(coupler_chksum_type), intent(in) :: coupler_chksum_obj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need to be documented
thomas-robinson
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, three coupler subroutines have been defined and used in coupler_main
The same
coupler_update_atmos_model_radiation
subroutine is called regardless of the value of do_concurrent_radiation. The chksum call in the this coupler subroutine is turned off when do_concurrent_radiation= .True.Lastly,
serial_radiation
andconcurrent_radiation
clocks have been removed. One clock,radiation
is used.