Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'set -u' to all shell scripts #7

Merged
merged 4 commits into from
Aug 19, 2020
Merged

Add 'set -u' to all shell scripts #7

merged 4 commits into from
Aug 19, 2020

Conversation

DusanJovic-NOAA
Copy link
Contributor

Only build scripts that are currently used by stack custom.yaml and stack_wcoss_dell_p3.yaml are tested.

DusanJovic-NOAA and others added 4 commits August 18, 2020 20:31
* add hera configs

* update compiler and mpi combo

* remove tar.gz after download

* hera config
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in essence:
value of ${variable:-} is "" if ${variable} is undefined.

@aerorahul aerorahul merged commit dd33d58 into NOAA-EMC:develop Aug 19, 2020
@DusanJovic-NOAA DusanJovic-NOAA deleted the set_minus_u branch August 19, 2020 21:21
DusanJovic-NOAA added a commit to DusanJovic-NOAA/hpc-stack that referenced this pull request Aug 21, 2020
* Use 'set -u' to treat use of unset variables as error

* Feature/hera (NOAA-EMC#6)

* add hera configs

* update compiler and mpi combo

* remove tar.gz after download

* hera config

* Do not redirect build outputs to a log file
Update libs/build_*.sh

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants