Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1.2.0 updates #206

Merged
merged 10 commits into from
Apr 16, 2021
Merged

Feature/1.2.0 updates #206

merged 10 commits into from
Apr 16, 2021

Conversation

kgerheiser
Copy link
Contributor

Fix DOWNLOAD_ONLY option by removing git fetch, using autotools build of PIO, and using git reset --hard && git clean to clean ESMF instead of re-downloading it.

Fix test options by swapping make check with make test for PNG and Jasper

Update ESMF to bs 47 which is what the weather model currently uses

Update PIO to 2.5.3 to fix a bug with make check

Remove nceppost. I don't think this it is needed anymore.

@kgerheiser kgerheiser requested a review from aerorahul April 12, 2021 15:28
@arunchawla-NOAA
Copy link

Hi ESMF has done a formal 8.1.0 release does it make sense to just move to this? This is for @junwang-noaa with regards to ufs-weather-model

@junwang-noaa
Copy link

junwang-noaa commented Apr 12, 2021 via email

@kgerheiser
Copy link
Contributor Author

Ok, I'll change that to the 8.1.0 release then.

@kgerheiser
Copy link
Contributor Author

The Boost download site is down which is causing the build errors.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment in CDO.

libs/build_cdo.sh Outdated Show resolved Hide resolved
@kgerheiser kgerheiser requested a review from aerorahul April 16, 2021 14:51
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@aerorahul aerorahul merged commit 9073599 into NOAA-EMC:develop Apr 16, 2021
@kgerheiser kgerheiser deleted the feature/1.2.0-updates branch April 16, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants