Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ww3_doxy_tmpl.md: clarify MODULE markup #606

Merged

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

Pull Request Summary

Clarifies the doxygen markup specific to Fortran MODULE.

Description

Provide a detailed description of what this PR does.

  • Corrects the doxygen markup that is needed for the MODULE Fortran code unit. The previous doxygen fix PR clarified that the @param tag was not used for MODULE variables. In hindsight, it should have also been clarified that there are two sections for it: a header that stays above the MODULE line, and then the inline variable documentation that go below it.

What bug does it fix, or what feature does it add?

  • Addresses a confusing part of the header template file, docs/ww3_doxy_tmpl.md.

Is a change of answers expected from this PR?

  • No. Only the header template file has been changed.

Please also include the following information:

  • Add any suggestions for a reviewer

  • Mention any labels that should be added:

    • documentation.
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply:

    • No answers are expected to change. No source code has been edited.

Issue(s) addressed

  • Please list any issues associated with this PR, including those the PR will fix/close. For example:
    • N/A.

Commit Message

ww3_doxy_tmpl.md: clarify MODULE markup

Check list

Testing

  • How were these changes tested?
    • No source code changes, so nothing to test.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    • No. Not required for documentation.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • N/A. See above.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    • N/A. See above.
  • Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).
    • No changes.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    • N/A. See above.

@JessicaMeixner-NOAA
Copy link
Collaborator

No regtests run as it's just a doxygen file update

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit e6d27b9 into NOAA-EMC:develop Feb 9, 2022
@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the doc/header-fix branch March 7, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants