Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uniformize regtests output option #605

Merged
merged 2 commits into from
Feb 9, 2022
Merged

uniformize regtests output option #605

merged 2 commits into from
Feb 9, 2022

Conversation

mickaelaccensi
Copy link
Collaborator

Pull Request Summary

add option -o all in matrix_*
except for ukmo which is -o both
remove all -o statements in matrix.base
correct a test in run_test to avoid warnings

Description

uniformize the option -o to setup the kind of output type (ascii, netcdf, grib) in the main matrix script

Issue(s) addressed

Commit Message

uniformize regtests output by setting a global output type in the matrix script

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    yes all
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    on going on datarmor with intel compiler
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
  • Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@mickaelaccensi
add option -o all in matrix_*
f40b873 
except for ukmo which is -o both
remove all -o statements in matrix.base
correct a test in run_test to avoid warnings
@mickaelaccensi mickaelaccensi requested review from aliabdolali and JessicaMeixner-NOAA and removed request for aliabdolali February 8, 2022 17:30
@JessicaMeixner-NOAA
Copy link
Collaborator

Thanks for making this a separate PR!

@JessicaMeixner-NOAA
Copy link
Collaborator

Started running the regtests so we can document what output changes and make sure everything runs if we are triggering any additional outputs.

@JessicaMeixner-NOAA
Copy link
Collaborator

So I got one error with the test:
in run_test -b slurm -o all -c hera.intel -S -T -w work_IC2IS2 ../model ww3_tic2.2

 *** WAVEWATCH III ERROR IN W3OUTP :
     ERROR IN READING FROM INPUT FILE
     LAST POINT INDEX IS NOT -1
     OR TOO MANY POINT INDEXES DEFINED

Did you have any issues with this test @mickaelaccensi ? I'm running the comparison now and will look into this error later today.

@mickaelaccensi
Copy link
Collaborator Author

So I got one error with the test: in run_test -b slurm -o all -c hera.intel -S -T -w work_IC2IS2 ../model ww3_tic2.2

 *** WAVEWATCH III ERROR IN W3OUTP :
     ERROR IN READING FROM INPUT FILE
     LAST POINT INDEX IS NOT -1
     OR TOO MANY POINT INDEXES DEFINED

Did you have any issues with this test @mickaelaccensi ? I'm running the comparison now and will look into this error later today.

yes, I've made the corrections and pushed them

@JessicaMeixner-NOAA
Copy link
Collaborator

The fix worked for me, running the matrix.comp now.

@JessicaMeixner-NOAA
Copy link
Collaborator

Only the known not b4b:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (9 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (5 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

Output:
matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 82e34ba into NOAA-EMC:develop Feb 9, 2022
aliabdolali pushed a commit that referenced this pull request Mar 16, 2022
@mickaelaccensi @aliabdolali
uniformize regtests output by setting a global output type in the mat…
f40315c 
…rix script (#605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA approved these changes

@aliabdolali aliabdolali Awaiting requested review from aliabdolali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uniformize matrix outputs
2 participants
@mickaelaccensi @JessicaMeixner-NOAA