I have cloned your fork and checked out branch bugfix/nfcens_wafs.

The wafs changes look good. I ran wafs processing. I grepped on cmdfile in the log file in both my test and in the latest emc.vpppg runs.

[dlogin07 /lfs/h2/emc/ptmp/shelley.melchior/EVS_out]$ grep cmdfile jevs_wafs_stats.o121727939 
0 + '[' -s wafs_stat.cmdfile ']'
1 + mpiexec -np 4 -cpu-bind verbose,core cfp wafs_stat.cmdfile

[dlogin07 /lfs/h2/emc/ptmp/shelley.melchior/EVS_out]$ grep cmdfile ../../emc.vpppg/output/jevs_wafs_stats.o121656992 
0 + '[' -s wafs_stat.cmdfile ']'
0 + echo 'WARNING: wafs_stat.cmdfile DOES NOT EXIST'
WARNING: wafs_stat.cmdfile DOES NOT EXIST
1 + mpiexec -np 4 -cpu-bind verbose,core cfp wafs_stat.cmdfile

The WARNING was removed is no longer part of the if test. ✔️

stats processing completed successfully.

The AQM change looks fine and align with NCO SPA suggestion. I do not believe I can test it since our dev driver scripts override COMIN and COMOUT default settings.

The ecf changes can't be tested. But @SamiraArdani-NOAA checked that the equivalent dev driver scripts had the appropriate #PBS -N naming convention. prep and stats looked good already. plots needed updating. I ran nfcens plots. The job is now the proper name, as born out in the name of the logfile:
/lfs/h2/emc/ptmp/shelley.melchior/EVS_out/jevs_nfcens_wave_grid2obs_plots.o121728373
vs the name in the latest run of nfcens plots in the emc.vpppg parallel:
/lfs/h2/emc/ptmp/emc.vpppg/output/jevs_nfcens_grid2obs_plots.o121680647

plots processing completed successfully. ✔️

I was trying to find the mkdir -p ${DATA}/sfcshp manifest in the output log file. In trying to track it down, I think we need to add the err_chk to return from the processes of evs_wave_timeseries.sh and evs_wave_leadaverages.sh in exevs_nfcens_wave_grid2obs_plots.sh.

See lines 99-102 of exevs_nfcens_wave_grid2obs_plots.sh

${USHevs}/${COMPONENT}/evs_wave_timeseries.sh

## lead_averages
${USHevs}/${COMPONENT}/evs_wave_leadaverages.sh
  

I think the following line needs to be put after each call to run the USHevs scripts:
export err=$?; err_chk

Do you agree? If so, I think we need to do this as something that was missed in the EE2 checklist.

I ran nfcens plots w/ SENDDBN set up for FAKE dbn_alert. The new for loop works correctly for the FAKE dbn_alert set up. ✔️

The re-run of nfcens plotting to include err_chk worked correctly. From the logfile (/lfs/h2/emc/ptmp/shelley.melchior/EVS_out/jevs_nfcens_wave_grid2obs_plots.o121773518):

+ 3 + /lfs/h2/emc/vpppg/noscrub/shelley.melchior/EVS/ush/nfcens/evs_wave_timeseries.sh
+ 6 + export err=0
+ 6 + err=0
+ 6 + err_chk
 completed cleanly
+ 6 + /lfs/h2/emc/vpppg/noscrub/shelley.melchior/EVS/ush/nfcens/evs_wave_leadaverages.sh
+ 6 + export err=0
+ 6 + err=0
+ 6 + err_chk
 completed cleanly

The plots tar files are generated and match closely with emc.vpppg.

@AliciaBentley-NOAA, @PerryShafran-NOAA , I recommend this PR for merge. However, I will not merge it yet, allowing the chance for your review.

@SamiraArdani-NOAA @ShelleyMelchior-NOAA I have looked over this PR and think it is good to go! Thank you!