Feature/ee2 final wafs #335
Conversation
…NOAA/EVS into feature/ee2-nfcens
…rdani-NOAA/EVS into feature/EE2_final_nfcens
|
HI Samira! Your PR looks good upon first glance. I will set it up to run wafs stats. |
|
The stats processing has completed! |
|
@ShelleyMelchior-NOAA : The outputs were identical to emc.vpppg parallel. The .o file also look good. |
|
Fantastic! Thanks for the quick response. I will not merge this PR yet. I will allow an opportunity for @AliciaBentley-NOAA to review the changes. I will merge once she has had a chance to look over the PR. |
|
@ShelleyMelchior-NOAA : Sounds great. Thank you! |
|
@ShelleyMelchior-NOAA Please ask Samira to add the needed AQM lines into this PR! After that, it can be merged. Thanks! |
|
HI @SamiraArdani-NOAA -- we are going to use your PR to work in one oversight in the recently merged AQM PR. There are 2 driver scripts that need an update. Please add the following line at line 56 of Please add the following line above line 58 of To see the request already in place, you can browse the para branch of the EVS github repository. |
|
@ShelleyMelchior-NOAA @AliciaBentley-NOAA : Just to clarify, do you want me to do these changes in aqm? because I worked on wafs. |
|
Correct. We need the change into the main code base. Instead of opening a new PR by me or Perry, we thought it would be more efficient to integrate this small change into an open PR. Yours is ready for merge so we thought it would be best to have you put the change in. If you are uncertain, I can put the change into this open PR for you. |
|
@ShelleyMelchior-NOAA Thanks! I would not be opposed to you adding these two lines and merging the WAFS PR. Lin will begin the EE2 review on Monday, so it would be good to get this PR merged (and maybe added to the parallel) over the weekend. Thanks! |
|
@SamiraArdani-NOAA , upon recommendation from @AliciaBentley-NOAA , for the interest of time, I went ahead and made the requested changes. Next, I will do the formal code review and approve this PR for merge. |
Pull Request Testing
Describe testing already performed for this Pull Request:
In this PR, the rest of the EE2 -final items were modified. The scripts were tested.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
There is no prep STEP for this component.
stats STEP script: jevs_wafs_atmos_stats.sh
plots STEP script: jevs_wafs_atmos_plots.sh
Has the code been checked to ensure that no errors occur during the execution? [Yes]
Do these updates/additions include sufficient testing updates? [Yes]
Please complete this pull request review by [Fill in date].
Pull Request Checklist
Review the source issue metadata (required labels, projects, and milestone).
Complete the PR description above.
Ensure the PR title matches the feature branch name.
Check the following:
Instructions provided on how to run
Developer's name is replaced by ${user} where necessary throughout the code
Check that the ecf file has all the proper definitions of variables
Check that the jobs file has all the proper settings of COMIN and COMOUT and other input variables
Check to see that the output directory structure is followed
Be sure that you are not using MET utilities outside the METplus wrapper structure
After submitting the PR, select Development issue with the original issue number.
After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
Close the linked issue.