Remove REQUIRED keyword from find_package(MPI) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think merging this is fine, since MPI is later on only linked if the desired component is found. |
aerorahul
reviewed
Jul 6, 2021
| @@ -183,7 +183,7 @@ else() | |||
| endif() | |||
|
|
|||
| if(NetCDF_PARALLEL) | |||
| find_package(MPI REQUIRED) | |||
| find_package(MPI) | |||
There was a problem hiding this comment.
If NetCDF_PARALLEL is True and MPI is not found, wouldn't the linkages of the netcdf library be incomplete?
There was a problem hiding this comment.
In the case described in #50, this works.
On the other hand, what is the reasoning for the second check for the MPI components then?
CMakeModules/Modules/FindNetCDF.cmake
Line 249 in 12f5cc2
There was a problem hiding this comment.
@kgerheiser also said, this would be fine: #50 (comment)
kgerheiser
approved these changes
Jul 6, 2021
|
Will merge then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50
Using this with the described setting of #50, I get the following messages:
-- Could NOT find MPI_Fortran (missing: MPI_Fortran_WORKS) -- Could NOT find MPI (missing: MPI_Fortran_FOUND) Reason given by package: MPI component 'C' was requested, but language C is not enabled. MPI component 'CXX' was requested, but language CXX is not enabled.but compilation works afterwards.