Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version checking to FindESMF #49

Merged
merged 1 commit into from
May 20, 2021
Merged

Add version checking to FindESMF #49

merged 1 commit into from
May 20, 2021

Conversation

kgerheiser
Copy link
Contributor

@kgerheiser kgerheiser commented May 20, 2021

The version can be specified with find_package(ESMF 8.1.0 REQUIRED)

If a beta snapshot of ESMF is installed the variable ESMF_BETA_SNAPSHOT will be set

@kgerheiser kgerheiser requested a review from aerorahul May 20, 2021 14:37
@aerorahul aerorahul requested a review from DusanJovic-NOAA May 20, 2021 14:38
Copy link
Collaborator

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I wrote most of this, I should not approve my own changes 😜

@aerorahul
Copy link
Collaborator

Could you add in the description the update needed to the interface? I think something like:

find_package(ESMF 8.1.0 REQUIRED)

would be useful

@kgerheiser
Copy link
Contributor Author

In the PR description, or the commit, or where?

@aerorahul
Copy link
Collaborator

In the PR description, or the commit, or where?

In the PR description.
"Adding changes that went into UFS_UTILS" is not descriptive of the changes in FindESMF.cmake.

@kgerheiser kgerheiser merged commit 12f5cc2 into NOAA-EMC:develop May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants