Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timesince attribute to correct "YEAR" calculation for landuse data tool #1112

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Add timesince attribute to correct "YEAR" calculation for landuse data tool #1112

merged 5 commits into from
Nov 21, 2023

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Nov 1, 2023 •
edited
Loading

Description:

Fixes an error in how the YEAR variable on the output dataset is calculated.

Collaborators:

Expectation of Answer Changes:

Not answer changing to the fates results.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux added the PR status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration. label Nov 1, 2023
@glemieux glemieux mentioned this pull request Nov 2, 2023
Closed
13 tasks
@glemieux
Copy link
Contributor Author

glemieux commented Nov 7, 2023

Charlie tested this update on perlmutter and it crashed due to input_dataset.time.units.split() not working since there is not units attribute to time.

@glemieux
correct the way YEAR is updated
58732e5 
Since regridding skips 'timesince' in the input dataset
(and isn't necessary to regrid), simply pass the value
from the original ds_luh2 dataset
@glemieux
start setting up a refactor of the luh2 shell script
0913be7
@glemieux
fix how luh2 data tool check luh2 file type
17ed1b3
@glemieux
adding attribute copy to luh2 data tool to avoid losing unit data dur…
77899da 
…ing regrid
@glemieux glemieux changed the title [WIP] add timesince to correct "YEAR" calculation for landuse data tool Add timesince to correct "YEAR" calculation for landuse data tool Nov 13, 2023
@glemieux
Copy link
Contributor Author

Charlie tested this update on perlmutter and it crashed due to input_dataset.time.units.split() not working since there is not units attribute to time.

This has been addressed via 77899da. It is a workaround for issue pydata/xarray#8047 (discovered via pangeo-data/xESMF#286).

@glemieux glemieux added type: tools This PR adds or updates support tools. No regression testing necessary. and removed PR status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration. labels Nov 13, 2023
@glemieux glemieux changed the title Add timesince to correct "YEAR" calculation for landuse data tool Add timesince attribute to correct "YEAR" calculation for landuse data tool Nov 13, 2023
@glemieux glemieux merged commit 30cc0ca into NGEET:main Nov 21, 2023
1 check passed
@glemieux glemieux deleted the tools/luh2-yearfix branch January 3, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgknox rgknox rgknox approved these changes

Assignees
No one assigned
Labels
type: tools This PR adds or updates support tools. No regression testing necessary.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glemieux @rgknox