-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PULL_REQUEST_TEMPLATE.md #1070
Conversation
Slight rewording to PR template revisions
I think installing https://github.com/marketplace/task-list-completed to our repo would help give more weight to the checklist. I would install this app after this PR merge. CTSM currently uses this app as well. Note that it |
Thanks @glemieux. Can that package handle an either/or checkbox case as in my proposed revision here? |
@ckoven it looks like not yet based on this issue: stilliard/github-task-list-completed#21. Based on that, I think I would modify this PR to add a "Documentation" subsection that we ask people to fill out with either the url or a comment stating no update necessary. Then the checklist button could become a directive to respond to that subsection (which is similar to what we do for the "Testing" subsection now):
|
@ckoven I updated the original PR with the changes above: https://github.com/NGEET/fates/pull/1069/files |
FYI here is the CAM template for PRs https://github.com/ESCOMP/CAM/blob/main/.github/ISSUE_TEMPLATE/enhancement_request.yml |
Thanks @adrifoster |
It looks like this is using a beta feature (that's been in beta since 2021) and may only be for issue templates currently. I'll give this a try on my personal repo to confirm. |
Ah darn okay. thanks for checking it out. |
I just tested this on an old private repo and can confirm the forms don't seem to work for PRs yet. I did try the issue form version and that worked like a charm though! |
Slight rewording to PR template revisions
Description:
Collaborators:
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: