Update PULL_REQUEST_TEMPLATE.md #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the PR template to direct contributors to create an issue on the fates technical and/or user's guide as necessary so that we can track what needs updating.
glemieux
added
the
github
Adding a subsection for documentation and changing the checklist language
|
Referencing comment for posterity since I meant to write it here initially: #1070 (comment) |
|
@glemieux I love the links to the documentation, great addition. I think the new template is an improvement. Question, should we split the checklist into things that the author needs to do, and things that either the integrators (us) and/or author+integrators need to do? |
That's a good idea. |
Note which checklist item is the responsibility of the contributor or the integrator
5 tasks
rgknox
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updating the PR template to direct contributors to create an issue on the fates technical and/or user's guide as necessary so that we can track what needs updating.
Resolves #1068
Collaborators:
@ckoven @rgknox
Expectation of Answer Changes:
No, as this is a github template change
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: