Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split associate statement to avoid NAG compiler line continuation issue #1009

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Mar 31, 2023

Description:

Fixes #1010 by splitting the associate statement up into multiple associate calls. The split was made at what appears to be the maximum number of line continuations that the nag compiler will allow.

Also includes simple b4b updates for the following:

Collaborators:

@ekluzek

Expectation of Answer Changes:

Should be B4B

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

The nag compiler has a limit on the number of line continuations
@glemieux
Copy link
Contributor Author

@rgknox I'm going to look for some other simple issues that we can maybe roll into this B4B PR. Do you have any recommendations? Maybe #969?

glemieux added 3 commits April 3, 2023 09:52
The user should be directed to update the HLM specific
name for the namelist variable, not the intermediate
variable that is used to pass the setting value from
the hlm to fates.  See clm_varctl.F90 for definitions.
@glemieux
Copy link
Contributor Author

glemieux commented Apr 4, 2023

Regression testing on cheyenne is complete. All expected tests pass B4B.

Folder: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1009-fates

@glemieux glemieux merged commit 5bb6e3e into NGEET:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants