Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/public-v4: additional python3 bug fixes #303

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jun 16, 2020

This PR contains additional bugfixes for Python 3 (from master). Without these, using Python 3 users on certain machines (including Stampede) will see an Exception from ccpp_prebuild.py and the build is broken.

Associated PRs:
#303
NOAA-EMC/fv3atm#130
ufs-community/ufs-weather-model#149

For regression testing information, see below ufs-community/ufs-weather-model#149.

@climbfuji
Copy link
Collaborator Author

@grantfirl @llpcarson can you please look at this briefly? These changes have been reviewed previously for merging into the master branch. Thanks, Dom.

@climbfuji climbfuji changed the title release/public-v4: additional python3 bug fixes for MRW App release v1.1 release/public-v4: additional python3 bug fixes Jun 18, 2020
Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@climbfuji climbfuji merged commit d2beebf into NCAR:release/public-v4 Jun 19, 2020
@climbfuji climbfuji deleted the ufs_public_release_v1_additional_python3_bugfixes branch June 27, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants