Handle the case where complement has a GCS #74
Conversation
j9ac9k
force-pushed
the
local-crs-issue-ogi
branch
from
5bd630a to
58152fb
Compare
j9ac9k
force-pushed
the
local-crs-issue-ogi
branch
from
602278d to
8564d97
Compare
| @@ -134,6 +136,21 @@ def resolution(self, value: float) -> None: | |||
| self._resolution = value | |||
| return None | |||
|
|
|||
| def _PCS_from_GCS( | |||
There was a problem hiding this comment.
This isn't a great name for this function. What you're doing here is computing a possible UTM zone in which to do your operations.
| utm_crs_list = pyproj.database.query_utm_crs_info( | ||
| datum_name="WGS 84", | ||
| area_of_interest=pyproj.aoi.AreaOfInterest( | ||
| west_lon_degree=affine.c, |
There was a problem hiding this comment.
you passing c and f for both east/north south/west. Is that what you want? Shouldn't you be passing the bounds of the fnd_obj?
There was a problem hiding this comment.
Not in this case. This function is called when codem is trying to calculate the resolution for a given dataset. At this stage in the processing pipeline, the compliment and foundation have no knowledge of each other; which is why I call the CRS a best_guess_crs that is later overridden by the foundation CRS.
Given that this is the only time this function is called, the code should likely just be merged into the elif not data.crs.is_projected code-block, I'll make that change.
Given that this is only called in that step, this likely should not be a function, but that bit should be merged into
When the compliment dataset has a global coordinate system, care must be taken to project that system into a PCS before registration can take place. This is largely due to codem being dependent on the resolution for the transformation matrix associated with the dataset (in a GCS the units are degrees, not meters/feet).