Fix get_namespace tag problems #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLoses #140 Fixes a problem where `files::get_namespace` wouldn't work properly if the path contained the word `functions` at any point. This is actually not backwards-compatible due to the change of return type from `Result<&str, &str>` to `Result<String, &str>`, but the API isn't stable and isn't used by anyone else so it seems ok to release as a patch.
github-actions
bot
added
lib
MysteryBlokHed
added a commit
that referenced
this pull request
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140
Fixes a problem where
files::get_namespacewouldn't work properly if the path contained the wordfunctionsat any point. This is actually not backwards-compatible due to the change of return type fromResult<&str, &str>toResult<String, &str>, but the API isn't stable and isn't used by anyone else so it seems ok to release as a patch.