Add network_utils directory and move network/transport into it #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
requested review from
huitseeker,
patrickkuo,
sblackshear,
gdanezis and
oxade
lxfind
force-pushed
the
separate-network-dir
branch
from
765b723 to
621cc13
Compare
sblackshear
approved these changes
Jan 29, 2022
gdanezis
approved these changes
Jan 29, 2022
lxfind
force-pushed
the
separate-network-dir
branch
2 times, most recently
from
0164a4a to
807e0b8
Compare
lxfind
force-pushed
the
separate-network-dir
branch
from
807e0b8 to
163b8cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards refactoring client code.
To start, we should separate the network utility functions with the client/server setups.
This PR does the following:
AuthorityClientinto client.rs so that it's together with the struct definition; moveMassClientout to a separate file as it's completely independent; Rename the rest of network.rs to server_lib.rs as it now only contains server related stuff.Next step:
We will start to rename the Client in network.rs, and also separate out network vs non-network stuff in server_lib.