[bridge] add watchdog to bridge node #19878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
longbowlu
force-pushed
the
bridge-auth-agg-metrics
branch
from
b5c2c54 to
b89985a
Compare
longbowlu
force-pushed
the
add-watchdog-to-bridge-node
branch
from
9a538a1 to
b89985a
Compare
longbowlu
changed the title
longbowlu
force-pushed
the
add-watchdog-to-bridge-node
branch
from
8d3ba77 to
4f24daa
Compare
Bridgerz
reviewed
Oct 18, 2024
| watchdog_config: Some(WatchdogConfig { | ||
| total_supplies: BTreeMap::from_iter(vec
There was a problem hiding this comment.
This is just for mainnet correct?
There was a problem hiding this comment.
this is just an example if you expand up
| // 2. i64::MAX is 9_223_372_036_854_775_807, with 8 decimal places is | ||
| // 92_233_720_368. We likely won't see any balance higher than this | ||
| // in the next 12 months. | ||
| let balance = (balance / self.ten_zeros).as_u64() as i64; |
There was a problem hiding this comment.
This only works for Eth decimals tho right? We'll need to update this when we include tokens with decimals other than 18 ya?
There was a problem hiding this comment.
so if we leave it as is and add a new token with a different decimal is the reported balance for that token will be a little off until we update.
There was a problem hiding this comment.
we will have to update this before the new token is added
| } | ||
|
|
||
| fn interval(&self) -> Duration { | ||
| Duration::from_secs(2) |
There was a problem hiding this comment.
should this match eth_bridge_status duration?
There was a problem hiding this comment.
see #19878 (comment)
Bridgerz
approved these changes
Oct 18, 2024
longbowlu
added a commit
that referenced
this pull request
Oct 18, 2024
## Description 1. run watchdogs on bridge nodes. 2. merges `sui-bridge-watchdog` to `sui-bridge` crate, so there is no circular dependencies ## Test plan unit tests, will deploy locally and test --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sui-bridge-watchdogtosui-bridgecrate, so there is no circular dependenciesTest plan
unit tests, will deploy locally and test
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.