More optimizations to package load #14762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
oxade
reviewed
Nov 10, 2023
| { | ||
| // TODO: Can this lock ever block execution? | ||
| // TODO: Why do we need a RwLock anyway??? | ||
| self.runtime_packages_loaded_from_db |
There was a problem hiding this comment.
This lock is for interior mutability since we only take self as read ref
oxade
approved these changes
Nov 10, 2023
lxfind
force-pushed
the
performance-opt-package-more
branch
from
0fbf864 to
1c039d3
Compare
mystenmark
reviewed
Nov 10, 2023
| @@ -54,7 +54,7 @@ pub struct TemporaryStore<'backing> { | |||
|
|
|||
| /// Every package that was loaded from DB store during execution. | |||
| /// These packages were not previously loaded into the temporary store. | |||
| runtime_packages_loaded_from_db: RwLock<BTreeMap<ObjectID, Object>>, | |||
| runtime_packages_loaded_from_db: RwLock<BTreeMap<ObjectID, PackageObjectArc>>, | |||
There was a problem hiding this comment.
we should consider just switching to DashMap
mystenmark
reviewed
Nov 10, 2023
| @@ -63,7 +63,7 @@ pub struct TemporaryStore<'backing> { | |||
|
|
|||
| /// Every package that was loaded from DB store during execution. | |||
| /// These packages were not previously loaded into the temporary store. | |||
| runtime_packages_loaded_from_db: RwLock<BTreeMap<ObjectID, Object>>, | |||
| runtime_packages_loaded_from_db: RwLock<BTreeMap<ObjectID, PackageObjectArc>>, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that we still spend a non-trivial amount of time loading packages in execution. After digging in, I realized that this is mostly due to us trying to save all runtime loaded packages.
This PR minimizes that overhead by:
This fix is sufficient to make the package load disappear in a local benchmark, and we are seeing about 10% improvements in throughout in the baseline mode. So this is good enough for now.
However as a long term fix, I think a proper solution is that we should introduce a verbose flag to execution. Normally the verbose flag is off. When we detect a fork, we rerun the execution with the verbose flag on so that we could collect more information for the debug state dump.
Also fixed the execution-only mode in the local benchmark to use the package cache, otherwise we would see a ton of unnecessary clones there.
Test Plan
CI
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes