Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get a ZK signature instead of relying on BCS #13546

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Jordan-Mysten
Copy link
Contributor

Description

This will simplify a decent amount of the process.

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@Jordan-Mysten Jordan-Mysten requested review from a team as code owners August 30, 2023 00:58
@Jordan-Mysten Jordan-Mysten requested review from hayes-mysten and removed request for a team August 30, 2023 00:58
@vercel vercel bot temporarily deployed to Preview – mysten-ui August 30, 2023 00:59 Inactive
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 7:27pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 7:27pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2023 7:27pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2023 7:27pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2023 7:27pm

Copy link
Contributor

@hayes-mysten hayes-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love that we mix camel and snake case throughout the API, but I imagine fixing that is a much bigger topic.

@Jordan-Mysten Jordan-Mysten force-pushed the jordan--zk-add-signature-method branch from 26d2dfd to b3c87db Compare August 31, 2023 19:27
@vercel vercel bot temporarily deployed to Preview – mysten-ui August 31, 2023 19:27 Inactive
@Jordan-Mysten Jordan-Mysten merged commit 8384490 into main Sep 6, 2023
@Jordan-Mysten Jordan-Mysten deleted the jordan--zk-add-signature-method branch September 6, 2023 17:43
randall-Mysten pushed a commit that referenced this pull request Sep 6, 2023
## Description 

This will simplify a decent amount of the process.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants