-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to get a ZK signature instead of relying on BCS #13546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Mysten
requested review from
hayes-mysten
and removed request for
a team
August 30, 2023 00:58
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
hayes-mysten
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love that we mix camel and snake case throughout the API, but I imagine fixing that is a much bigger topic.
Jordan-Mysten
force-pushed
the
jordan--zk-add-signature-method
branch
from
August 30, 2023 01:05
300ce46
to
5e4655c
Compare
Jordan-Mysten
force-pushed
the
jordan--zk-add-signature-method
branch
from
August 30, 2023 01:06
5e4655c
to
26d2dfd
Compare
joyqvq
approved these changes
Aug 30, 2023
Jordan-Mysten
force-pushed
the
jordan--zk-add-signature-method
branch
from
August 31, 2023 19:27
26d2dfd
to
b3c87db
Compare
randall-Mysten
pushed a commit
that referenced
this pull request
Sep 6, 2023
## Description This will simplify a decent amount of the process. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will simplify a decent amount of the process.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes