Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts-sdk] deprecate getters in /types #13148

Merged
merged 2 commits into from
Jul 26, 2023
Merged

[ts-sdk] deprecate getters in /types #13148

merged 2 commits into from
Jul 26, 2023

Conversation

hayes-mysten
Copy link
Contributor

Description

Describe the changes or additions included in this PR.

Test Plan

How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@hayes-mysten hayes-mysten requested review from a team as code owners July 25, 2023 21:43
@hayes-mysten hayes-mysten requested review from williamrobertson13 and pchrysochoidis and removed request for a team July 25, 2023 21:43
@vercel
Copy link

vercel bot commented Jul 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 11:27pm
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 11:27pm
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 11:27pm
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 11:27pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 11:27pm
sui-wallet-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 11:27pm

@hayes-mysten hayes-mysten force-pushed the hayes/deprecate-getters branch from 6ba0c7d to 430b9d5 Compare July 25, 2023 21:44
@vercel vercel bot temporarily deployed to Preview – mysten-ui July 25, 2023 21:44 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit July 25, 2023 21:45 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@hayes-mysten hayes-mysten force-pushed the hayes/deprecate-getters branch from 430b9d5 to 8f49688 Compare July 25, 2023 22:06
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit July 25, 2023 22:06 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui July 25, 2023 22:07 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui July 25, 2023 23:04 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui July 25, 2023 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit July 25, 2023 23:07 Inactive
@hayes-mysten hayes-mysten force-pushed the hayes/deprecate-getters branch from c5b78d7 to 54f9c23 Compare July 25, 2023 23:08
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit July 25, 2023 23:08 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui July 25, 2023 23:09 Inactive
@hayes-mysten hayes-mysten force-pushed the hayes/deprecate-getters branch from 54f9c23 to fc8fce5 Compare July 25, 2023 23:12
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit July 25, 2023 23:12 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui July 25, 2023 23:13 Inactive
@hayes-mysten hayes-mysten force-pushed the hayes/deprecate-getters branch from fc8fce5 to e22b1ce Compare July 25, 2023 23:26
@vercel vercel bot temporarily deployed to Preview – mysten-ui July 25, 2023 23:27 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit July 25, 2023 23:27 Inactive
@hayes-mysten hayes-mysten merged commit 1b4ed77 into main Jul 26, 2023
@hayes-mysten hayes-mysten deleted the hayes/deprecate-getters branch July 26, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchrysochoidis pchrysochoidis pchrysochoidis approved these changes

@williamrobertson13 williamrobertson13 Awaiting requested review from williamrobertson13 williamrobertson13 is a code owner automatically assigned from MystenLabs/fe-and-apps

Assignees

@Jordan-Mysten Jordan-Mysten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hayes-mysten @pchrysochoidis @Jordan-Mysten