UI Base package #13024
Merged
UI Base package #13024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jordan-Mysten
force-pushed
the
jordan--ui-base
branch
from
1ce640d to
82b3303
Compare
Jordan-Mysten
force-pushed
the
jordan--ui-base
branch
from
82b3303 to
d761f3e
Compare
Jordan-Mysten
force-pushed
the
jordan--ui-base
branch
from
d761f3e to
efab8aa
Compare
Jordan-Mysten
requested review from
williamrobertson13 and
pchrysochoidis
and removed request for
a team
williamrobertson13
approved these changes
Jul 17, 2023
| </div> | ||
| ); | ||
| }, | ||
| } satisfies Meta<typeof Button>; |
There was a problem hiding this comment.
nioce improved type safety 😉
Jordan-Mysten
force-pushed
the
jordan--ui-base
branch
from
efab8aa to
4f40c60
Compare
williamrobertson13
approved these changes
Jul 17, 2023
| ({ variant, size, loading, children, before, after, asChild, ...props }, ref) => { | ||
| const Comp = asChild ? Slot : 'button'; | ||
|
|
||
| if (asChild && (loading || before || after)) { |
There was a problem hiding this comment.
Is there any benefit to enforcing this at the type level or too overkill maybe? This works fine though haha
There was a problem hiding this comment.
It's certainly possible, I was just thinking it's probably overkill, and I'm slowly getting convinced that consumers should just do the before / after themselves (loading is still iffy, but there's probably a clever way to do it without needing to compose the children layout).
Nikhil-Mysten
approved these changes
Jul 17, 2023
stefan-mysten
pushed a commit
to stefan-mysten/sui
that referenced
this pull request
Jul 18, 2023
## Description Describe the changes or additions included in this PR. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes