Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Update gtts #2699

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Update gtts #2699

merged 1 commit into from
Sep 30, 2020

Conversation

gaganpreet
Copy link
Contributor

@gaganpreet gaganpreet commented Sep 19, 2020 •
edited
Loading

Description

An upstream bug already fixed in gTTS: pndurette/gTTS#197

Everytime I asked Mycroft with a response sentence with the character m. in the text, it'd substitute it for 'monsieur'. e.g.: "bedroom.", "a.m."

How to test

Using google tts with mycroft use the cli "say a.m.", result is "a monsieur".

Contributor license agreement signed?

CLA [Not yet, I signed up on the link]
(Whether you have signed a CLA - Contributor Licensing Agreement

@devops-mycroft
Copy link

Hello, @gaganpreet, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devops-mycroft devops-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Sep 19, 2020
@forslund
Copy link
Collaborator

Oh nice! Glad to get that fixed!

forslund
forslund approved these changes Sep 19, 2020
View reviewed changes
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended!

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling
Copy link
Contributor

Hi @gaganpreet, let me know if you have any trouble with the CLA process. There's still some manual steps so things can get missed occassionally.

Thanks

@krisgesling krisgesling added Status: Accepted PR has been reviewed and accepted. There must be some reason why it isn't being merged. Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained. and removed Type: Bug - complex labels Sep 24, 2020
@gaganpreet
Copy link
Contributor Author

@krisgesling Thanks for checking in. I'm still waiting for next steps to sign the CLA, I haven't received any email about it yet.

@krisgesling
Copy link
Contributor

Hmm the chain must have broken down somewhere, can you email me directly kris.gesling@mycroft.ai and I'll get that to you asap 🙂

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Sep 30, 2020
@krisgesling
Copy link
Contributor

Received the CLA, thanks @gaganpreet

@krisgesling krisgesling merged commit 4d76d13 into MycroftAI:dev Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@forslund forslund forslund approved these changes

Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: Accepted PR has been reviewed and accepted. There must be some reason why it isn't being merged. Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaganpreet @devops-mycroft @forslund @krisgesling