Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move components to TS #2 #438

Merged
merged 59 commits into from
Aug 22, 2019
Merged

Move components to TS #2 #438

merged 59 commits into from
Aug 22, 2019

Conversation

raphaelvigee
Copy link
Member

Tracked in #400

@raphaelvigee raphaelvigee added the DNM /!\ DO NOT MERGE /!\ label Aug 5, 2019
@raphaelvigee
Copy link
Member Author

Closes #400

@raphaelvigee raphaelvigee removed the DNM /!\ DO NOT MERGE /!\ label Aug 15, 2019
@BrychanOdlum
Copy link
Contributor

Can't see anything wrong with the code, still want to spend a bit more time time tomorrow reviewing features to ensure none have been broken. Will keep you posted!

@raphaelvigee raphaelvigee mentioned this pull request Aug 21, 2019
Closed
BrychanOdlum
BrychanOdlum approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@BrychanOdlum BrychanOdlum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Super nice!

@raphaelvigee raphaelvigee merged commit 8eb2303 into master Aug 22, 2019
@raphaelvigee raphaelvigee deleted the feature/move-ts-2 branch August 22, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrychanOdlum BrychanOdlum BrychanOdlum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphaelvigee @BrychanOdlum