Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: For You page loading placeholder stays forever #242

Closed
dedeswim opened this issue Jan 23, 2019 · 3 comments
Closed

BUG: For You page loading placeholder stays forever #242

dedeswim opened this issue Jan 23, 2019 · 3 comments
Assignees
@BrychanOdlum
Labels
bug Something isn't working

Comments

@dedeswim
Copy link
Contributor

dedeswim commented Jan 23, 2019 •
edited
Loading

Describe the bug
After I open the "For You" page and the content loads, on top of the page, there is still a loading placeholder that stays there forever.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'For You'
  2. Wait for content to load

Expected behavior
Once the content is loaded, the placeholder should disappear.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browsers: Chrome 71, Firefox Developer Edition 65.0b12

I took a look around, I hope this is not duplicate.
@dedeswim dedeswim added the bug Something isn't working label Jan 23, 2019
@dedeswim dedeswim changed the title BUG: For You page loading placeholder stays BUG: For You page loading placeholder stays forever Jan 23, 2019
@codymikol
Copy link

codymikol commented Jan 23, 2019 •
edited
Loading

Do you have an apple music subscription? Could be related: #228

@dedeswim
Copy link
Contributor Author

dedeswim commented Jan 23, 2019 •
edited
Loading

Yep, I do 😄
The music loads, indeed, and in fact, I can listen to it. The problem is the placeholder that stays still even after the music has loaded.

@BrychanOdlum BrychanOdlum self-assigned this Jan 24, 2019
@BrychanOdlum
Copy link
Contributor

Can confirm, this happens when no data is returned. Will push a fix ASAP.

BrychanOdlum added a commit that referenced this issue Jan 24, 2019
@BrychanOdlum
For you page: When no results are returned, hide area instead of disp…
5a7d66d 
…laying loading animation. Fixes #242
@BrychanOdlum BrychanOdlum mentioned this issue Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrychanOdlum BrychanOdlum

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dedeswim @BrychanOdlum @codymikol