whitespace/tab fixes - fixes 728 #987
Conversation
|
Thanks, this should really be a check added to jshint can you please modify the jshint task to enable |
|
great idea, thanks @ryanseddon. |
|
Yep that's exactly what i was going to do. Cool.
I see you've already done that, heh. Can you squash your commits. |
|
=D! force pushed in 3e90a35 |
| @@ -105,7 +106,8 @@ module.exports = function( grunt ) { | |||
| files: [ | |||
| 'Gruntfile.js', | |||
| 'src/*.js', | |||
| 'feature-detects/*.js' | |||
| 'feature-detects/*.js', | |||
There was a problem hiding this comment.
This one isn't needed as the **/*.js will recursively grab every file in feature-detects
There was a problem hiding this comment.
removed
On Mon, Jul 15, 2013 at 12:01 AM, Ryan Seddon notifications@github.comwrote:
In Gruntfile.js:
@@ -105,7 +106,8 @@ module.exports = function( grunt ) {
files: [
'Gruntfile.js',
'src/*.js',
'feature-detects/*.js''feature-detects/*.js',This one isn't needed as the */.js will recursively grab every file in
feature-detects—
Reply to this email directly or view it on GitHubhttps://github.com//pull/987/files#r5183930
.
patrick
add whitespace check to jshint config, and make jshint scan subfolders
whitespace/tab fixes - fixes 728
|
Thanks @patrickkettner this should stop any more whitespace PRs \o/ |
|
Can we close #728 now then? |
whitespace/tab fixes - fixes 728
This fixes the reported issue in 728.
The good news is the amount of mixed tabs and trailing whitespace is much
smaller than it was at the time the initial report. The only outstanding
files are from caniuse, and node_modules.