Updated flexbox tests to better capture all 3 specs; fixes #812 #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why "tweener". I almost feel like it can be named "flexbox-ie10" as this is pretty universally known as the ie10 take on flexbox. |
|
I've seen it referred to as the "tweener" syntax in various places. "transitional" also suggested. I'm not precious over the name, although it doesn't quite feel right naming it after a specific browser (let alone version). Do we know for certain that IE11 will support the latest syntax? |
|
I'd prefer |
|
@paulirish – decision on this? |
|
"tweener" is fine for me. |
stucox
pushed a commit
that referenced
this pull request
Jul 6, 2013
Updated flexbox tests to better capture all 3 specs; fixes #812
Merged
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Updated flexbox tests to better capture all 3 specs; fixes Modernizr#812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #812.
Now have 3 flexbox tests:
Uses new
testAllProps()syntax so should probably wait until #933 is merged in.