Use CSS.supports() internally (fixes #818) #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return prefixed == 'pfx' ? prop : true; | ||
|
|
||
| // If value to test has been passed in, do a set-and-check test | ||
| if (!skipValueTest && !is(value, 'undefined')) { |
There was a problem hiding this comment.
Can we assume that value is falsy without doing an explicit test against undefined.
So just !value to me seems fine unless you've come across an edge case?
There was a problem hiding this comment.
Yeah there is a case: Chrome, Firefox & Opera all seem to agree that e.g. CSS.supports('width', 0) should be true.
If we think Modernizr.testProp() should match CSS.supports() as closely as possible, we should use !is(value, 'undefined') here to ensure we match this result, although the spec does say that CSS.supports() only needs to accept DOMStrings.
This also has me wondering if we should add a build option to actually polyfill the CSS.supports() API as an alias to testProp() if it isn't present...
What do you think?
The other corner case might have been empty strings, although interestingly they all agree that e.g. CSS.supports('display', '') should return false.
There was a problem hiding this comment.
Ah right good to know.
This also has me wondering if we should add a build option to actually polyfill the CSS.supports() API as an alias to testProp() if it isn't present...
Hmm not sure about that, maybe we could alias CSS.supports to Modernizr.supports and if no support alias that to testProp()? That way we leave it alone?
There was a problem hiding this comment.
Let's save that one for a separate discussion then. I might fork this to make a standalone polyfill.
|
Added a couple of comments to explain those corner cases. Good to merge...? |
…ion. Update references.
…ion. Update references.
…udes the x any y-axis radius of the rounded rectangles. This change modifies the expected file to match with the new behavior.
|
I'm going to try and squash this down then merge it in. |
|
Nice, will be great to have. |
added 2 commits
July 29, 2013 23:07
Update CSS Shapes test.
Modify CSS Exclusions to CSS Shapes, since we split up the specification.
|
Are you able to sqaush and merge this in @stucox ? |
commit 240927e8c379a7cc35822e4fb6c7724ef44bd0fb
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Aug 1 07:26:31 2013 +0100
Correcting JSON typo
commit 8729ddc
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Aug 1 07:19:58 2013 +0100
Squashed commit of the following:
commit 273372b18f20a2b50a395d63aee56d18c7675748
Merge: 375aba0 901fc80
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Aug 1 07:18:25 2013 +0100
Merge branch 'supports' of https://github.com/Modernizr/Modernizr into supports
Conflicts:
feature-detects/css/flexbox.js
commit 375aba0d7a2e8b6503b2c602c16170b9a9f494f5
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Aug 1 07:10:45 2013 +0100
Squashed commit of the following:
commit 1a916b843e7896fe3ea71b4cb9d32f40bd41664f
Merge: 901fc80 8cc5f1c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Aug 1 07:09:18 2013 +0100
Merge branch 'master' into supports
Conflicts:
feature-detects/css/flexbox.js
commit 901fc80
Author: Stu Cox <stuart.cox@gmail.com>
Date: Mon May 20 08:15:49 2013 +0100
Added some comments about corner cases in `src/testProps`
commit 29df5d9
Merge: ef920a5 98d877f
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu May 16 19:07:40 2013 +0100
Merge branch 'master' into supports
Conflicts:
feature-detects/css/resize.js
feature-detects/css/userselect.js
feature-detects/css/wrapflow.js
commit ef920a5
Merge: 03fa4e0 3c46f00
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu May 16 18:58:04 2013 +0100
Merge branch 'supports' of https://github.com/Modernizr/Modernizr into supports
commit 03fa4e0
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu May 16 18:57:44 2013 +0100
Revert "Revert "Added detect for <template> HTML tag""
This reverts commit ea9d5f3.
commit 3c46f00
Merge: 0af0315 899ee2f
Author: Stu Cox <stu@stucox.co.uk>
Date: Thu May 16 10:54:20 2013 -0700
Merge pull request #932 from stucox/supports
Corrected polarity of `skipValueTest` param in detects using `testAllProps()`
commit 899ee2f
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu May 16 18:37:02 2013 +0100
Corrected polarity of `skipValueTest` param in detects using `testAllProps()`
commit 0af0315
Merge: 16c8bc5 ee1fd0c
Author: Stu Cox <stu@stucox.co.uk>
Date: Wed May 15 05:55:51 2013 -0700
Merge pull request #927 from stucox/supports
Changed nativeTestProps to only support a single value (no prefixing)...
commit ee1fd0c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue May 14 11:18:10 2013 +0100
Changed nativeTestProps to only support a single value (no prefixing) and caveated a test which is only relevant when native detection *not* supported
commit 16c8bc5
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue May 14 10:11:42 2013 +0100
Updated comment re. try..catch in testProps
commit 50bbbf6
Merge: edd7b9c 7ab17c1
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue May 14 10:10:16 2013 +0100
Merge branch 'supports' of https://github.com/Modernizr/Modernizr into supports
commit 7ab17c1
Merge: 8cd9a02 3f5f372
Author: Stu Cox <stu@stucox.co.uk>
Date: Tue May 14 02:09:55 2013 -0700
Merge pull request #926 from ausi/fix/test-props
Fixed bug with setting a style property to a unknown value in IE8 and lower
commit 3f5f372
Author: Martin Auswöger <martin@auswoeger.com>
Date: Mon May 13 22:09:13 2013 +0200
Fixed bug with setting a style property to a unknown value in IE8 and lower
commit edd7b9c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Apr 26 18:23:49 2013 +0100
Tweak to border-image test value to pass correctly in Opera 12.15
commit 8cd9a02
Merge: 439fca4 429cb96
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 15:35:47 2013 +0100
Merge branch 'master' into supports
commit 439fca4
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 15:13:42 2013 +0100
Corrected tests following last commit
commit 0684b4b
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 14:45:24 2013 +0100
Changed `useValue` to `skipValueTest` and flipped its polarity, because that makes more sense
commit f5dd9cd
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 08:15:33 2013 +0100
Clarified `useValue=false` test
commit c5bc87e
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 08:07:11 2013 +0100
Updated detects to use the `useValue` attribute of `testAllProps()` where necessary
commit 525c8bf
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 00:37:08 2013 +0100
Corrected `testProp()` to handle the `useValue` argument correctly and added a test for it
commit 12d1b41
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 00:24:02 2013 +0100
Removed ability to test multiple values at once; that just confused the API
commit 528ecf5
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 00:17:38 2013 +0100
Revert "Changed testAllPropse to take an options argument, rather than a handful of flags"
This reverts commit 6d7136f.
commit 1c268fc
Merge: 180337f 24909eb
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Apr 17 22:51:03 2013 +0100
Merge branch 'master' into supports
Conflicts:
feature-detects/css/flexbox.js
feature-detects/css/flexboxlegacy.js
feature-detects/css/mask.js
feature-detects/css/wrapflow.js
src/testProp.js
commit 180337f
Merge: 0042ecd e81ed15
Author: Stu Cox <stuart.cox@gmail.com>
Date: Sat Mar 9 15:15:13 2013 -0600
Merge branch 'supports-featureupdates' into supports
commit 0042ecd
Author: Stu Cox <stuart.cox@gmail.com>
Date: Sat Mar 9 15:13:42 2013 -0600
Added a note about `undefined` return value from `nativeTestProps()`
commit e81ed15
Author: Stu Cox <stuart.cox@gmail.com>
Date: Sat Mar 9 15:08:14 2013 -0600
Updated other feature detects to use native detection
commit 2d1bc6c
Merge: 6d7136f 1d11554
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 17:21:40 2013 -0600
Merge branch 'supports' of https://github.com/Modernizr/Modernizr into supports
commit 6d7136f
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 17:11:20 2013 -0600
Changed testAllPropse to take an options argument, rather than a handful of flags
commit 11b8846
Merge: 9dc96a0 b466c5e
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 13:34:05 2013 -0600
Merge branch 'master' into supports
commit 9dc96a0
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 13:30:29 2013 -0600
Changed testProps' set-and-check to just return true on a *change* of a property for a given value, because browsers often reformat (e.g. '#ABCDEF' -> 'rgb(whatever)')
commit 45f054e
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 13:27:56 2013 -0600
Added values to mask, reflections and resize detects required for native detection
commit cc22178
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 09:33:03 2013 -0600
Fixed a bug where property values with spaces (e.g. "1px 1px") passed into `testAllProps` would be broken up
commit 4a64270
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Mar 6 13:42:48 2013 +0000
Tweaked a couple of `testAllProps()` values to fix some false negatives
commit 821ea66
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Mar 6 13:32:27 2013 +0000
Changed most detects using `testAllProps()` to define a property value, in order to be able to use `window.CSS.supports()` when available
commit 1d11554
Merge: 7bd7100 6acf06c
Author: Stu Cox <stu@stucox.co.uk>
Date: Tue Feb 26 15:19:49 2013 -0800
Merge pull request #842 from stucox/supports
Use `CSS.supports()` internally (#818)
commit 6acf06c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 23:17:34 2013 +0000
Stylistic tweaks following review comments
commit 5f6cf2c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 22:20:19 2013 +0000
Added `domToHyphenated` module which I forgot...
commit fdbea7e
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 20:03:51 2013 +0000
Removed some logging
commit ea9d5f3
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 19:45:04 2013 +0000
Revert "Added detect for <template> HTML tag"
This reverts commit 0252b52.
commit b850d2c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 19:44:06 2013 +0000
Updated `testProp()` and `testAllProps()` tests to cover value testing and removed some unneeded dependencies
commit 1ca3a01
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 19:38:18 2013 +0000
Made it so `testProp(prop, value)` and `testAllProps(prop, value)` will use a manual set-and-check to verify that the provided value is valid for the named property
commit 0cc5d3d
Merge: 6518dd6 0252b52
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 18:38:46 2013 +0000
Merge branch 'master' into supports
commit 6518dd6
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Feb 20 13:48:22 2013 +0000
Updated `testAllProps()` to accept a 2nd 'value' arg, and updated the `flexbox` and `flexboxlegacy` detects to demonstrate its use
commit 2372af5
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Feb 20 10:04:23 2013 +0000
Updated `testProp()` to accept a 2nd `value` arg for native feature detection, and rejigged (and renamed) the native wrapper to suit
commit a60c727
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Feb 20 10:01:21 2013 +0000
Rolled `flexbox` and `flexboxlegacy` detects back to original format (just using `testAllProps()`)
commit 82c9a43
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 19 23:24:49 2013 +0000
Revised version of nativeCSSDetect - this time only allows `(prop, value)` interface, because it's probably more common. Also updated `flexbox` and `flexboxlegacy` tests to show how it could be used.
commit 90b1874
Merge: 70ba7de fe93b62
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 19 22:09:15 2013 +0000
Merge branch 'master' into supports
commit 70ba7de
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 19 21:47:24 2013 +0000
Initial version of `nativeCSSDetect()` - only accepts a string e.g. `'(flex-wrap:reverse)'`; would quite like to overload the interface
commit 901fc80
Author: Stu Cox <stuart.cox@gmail.com>
Date: Mon May 20 08:15:49 2013 +0100
Added some comments about corner cases in `src/testProps`
commit 29df5d9
Merge: ef920a5 98d877f
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu May 16 19:07:40 2013 +0100
Merge branch 'master' into supports
Conflicts:
feature-detects/css/resize.js
feature-detects/css/userselect.js
feature-detects/css/wrapflow.js
commit ef920a5
Merge: 03fa4e0 3c46f00
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu May 16 18:58:04 2013 +0100
Merge branch 'supports' of https://github.com/Modernizr/Modernizr into supports
commit 03fa4e0
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu May 16 18:57:44 2013 +0100
Revert "Revert "Added detect for <template> HTML tag""
This reverts commit ea9d5f3.
commit 3c46f00
Merge: 0af0315 899ee2f
Author: Stu Cox <stu@stucox.co.uk>
Date: Thu May 16 10:54:20 2013 -0700
Merge pull request #932 from stucox/supports
Corrected polarity of `skipValueTest` param in detects using `testAllProps()`
commit 899ee2f
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu May 16 18:37:02 2013 +0100
Corrected polarity of `skipValueTest` param in detects using `testAllProps()`
commit 0af0315
Merge: 16c8bc5 ee1fd0c
Author: Stu Cox <stu@stucox.co.uk>
Date: Wed May 15 05:55:51 2013 -0700
Merge pull request #927 from stucox/supports
Changed nativeTestProps to only support a single value (no prefixing)...
commit ee1fd0c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue May 14 11:18:10 2013 +0100
Changed nativeTestProps to only support a single value (no prefixing) and caveated a test which is only relevant when native detection *not* supported
commit 16c8bc5
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue May 14 10:11:42 2013 +0100
Updated comment re. try..catch in testProps
commit 50bbbf6
Merge: edd7b9c 7ab17c1
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue May 14 10:10:16 2013 +0100
Merge branch 'supports' of https://github.com/Modernizr/Modernizr into supports
commit 7ab17c1
Merge: 8cd9a02 3f5f372
Author: Stu Cox <stu@stucox.co.uk>
Date: Tue May 14 02:09:55 2013 -0700
Merge pull request #926 from ausi/fix/test-props
Fixed bug with setting a style property to a unknown value in IE8 and lower
commit 3f5f372
Author: Martin Auswöger <martin@auswoeger.com>
Date: Mon May 13 22:09:13 2013 +0200
Fixed bug with setting a style property to a unknown value in IE8 and lower
commit edd7b9c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Apr 26 18:23:49 2013 +0100
Tweak to border-image test value to pass correctly in Opera 12.15
commit 8cd9a02
Merge: 439fca4 429cb96
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 15:35:47 2013 +0100
Merge branch 'master' into supports
commit 439fca4
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 15:13:42 2013 +0100
Corrected tests following last commit
commit 0684b4b
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 14:45:24 2013 +0100
Changed `useValue` to `skipValueTest` and flipped its polarity, because that makes more sense
commit f5dd9cd
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 08:15:33 2013 +0100
Clarified `useValue=false` test
commit c5bc87e
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 08:07:11 2013 +0100
Updated detects to use the `useValue` attribute of `testAllProps()` where necessary
commit 525c8bf
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 00:37:08 2013 +0100
Corrected `testProp()` to handle the `useValue` argument correctly and added a test for it
commit 12d1b41
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 00:24:02 2013 +0100
Removed ability to test multiple values at once; that just confused the API
commit 528ecf5
Author: Stu Cox <stuart.cox@gmail.com>
Date: Thu Apr 18 00:17:38 2013 +0100
Revert "Changed testAllPropse to take an options argument, rather than a handful of flags"
This reverts commit 6d7136f.
commit 1c268fc
Merge: 180337f 24909eb
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Apr 17 22:51:03 2013 +0100
Merge branch 'master' into supports
Conflicts:
feature-detects/css/flexbox.js
feature-detects/css/flexboxlegacy.js
feature-detects/css/mask.js
feature-detects/css/wrapflow.js
src/testProp.js
commit 180337f
Merge: 0042ecd e81ed15
Author: Stu Cox <stuart.cox@gmail.com>
Date: Sat Mar 9 15:15:13 2013 -0600
Merge branch 'supports-featureupdates' into supports
commit 0042ecd
Author: Stu Cox <stuart.cox@gmail.com>
Date: Sat Mar 9 15:13:42 2013 -0600
Added a note about `undefined` return value from `nativeTestProps()`
commit e81ed15
Author: Stu Cox <stuart.cox@gmail.com>
Date: Sat Mar 9 15:08:14 2013 -0600
Updated other feature detects to use native detection
commit 2d1bc6c
Merge: 6d7136f 1d11554
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 17:21:40 2013 -0600
Merge branch 'supports' of https://github.com/Modernizr/Modernizr into supports
commit 6d7136f
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 17:11:20 2013 -0600
Changed testAllPropse to take an options argument, rather than a handful of flags
commit 11b8846
Merge: 9dc96a0 b466c5e
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 13:34:05 2013 -0600
Merge branch 'master' into supports
commit 9dc96a0
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 13:30:29 2013 -0600
Changed testProps' set-and-check to just return true on a *change* of a property for a given value, because browsers often reformat (e.g. '#ABCDEF' -> 'rgb(whatever)')
commit 45f054e
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 13:27:56 2013 -0600
Added values to mask, reflections and resize detects required for native detection
commit cc22178
Author: Stu Cox <stuart.cox@gmail.com>
Date: Fri Mar 8 09:33:03 2013 -0600
Fixed a bug where property values with spaces (e.g. "1px 1px") passed into `testAllProps` would be broken up
commit 4a64270
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Mar 6 13:42:48 2013 +0000
Tweaked a couple of `testAllProps()` values to fix some false negatives
commit 821ea66
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Mar 6 13:32:27 2013 +0000
Changed most detects using `testAllProps()` to define a property value, in order to be able to use `window.CSS.supports()` when available
commit 1d11554
Merge: 7bd7100 6acf06c
Author: Stu Cox <stu@stucox.co.uk>
Date: Tue Feb 26 15:19:49 2013 -0800
Merge pull request #842 from stucox/supports
Use `CSS.supports()` internally (#818)
commit 6acf06c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 23:17:34 2013 +0000
Stylistic tweaks following review comments
commit 5f6cf2c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 22:20:19 2013 +0000
Added `domToHyphenated` module which I forgot...
commit fdbea7e
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 20:03:51 2013 +0000
Removed some logging
commit ea9d5f3
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 19:45:04 2013 +0000
Revert "Added detect for <template> HTML tag"
This reverts commit 0252b52.
commit b850d2c
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 19:44:06 2013 +0000
Updated `testProp()` and `testAllProps()` tests to cover value testing and removed some unneeded dependencies
commit 1ca3a01
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 19:38:18 2013 +0000
Made it so `testProp(prop, value)` and `testAllProps(prop, value)` will use a manual set-and-check to verify that the provided value is valid for the named property
commit 0cc5d3d
Merge: 6518dd6 0252b52
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 26 18:38:46 2013 +0000
Merge branch 'master' into supports
commit 6518dd6
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Feb 20 13:48:22 2013 +0000
Updated `testAllProps()` to accept a 2nd 'value' arg, and updated the `flexbox` and `flexboxlegacy` detects to demonstrate its use
commit 2372af5
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Feb 20 10:04:23 2013 +0000
Updated `testProp()` to accept a 2nd `value` arg for native feature detection, and rejigged (and renamed) the native wrapper to suit
commit a60c727
Author: Stu Cox <stuart.cox@gmail.com>
Date: Wed Feb 20 10:01:21 2013 +0000
Rolled `flexbox` and `flexboxlegacy` detects back to original format (just using `testAllProps()`)
commit 82c9a43
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 19 23:24:49 2013 +0000
Revised version of nativeCSSDetect - this time only allows `(prop, value)` interface, because it's probably more common. Also updated `flexbox` and `flexboxlegacy` tests to show how it could be used.
commit 90b1874
Merge: 70ba7de fe93b62
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 19 22:09:15 2013 +0000
Merge branch 'master' into supports
commit 70ba7de
Author: Stu Cox <stuart.cox@gmail.com>
Date: Tue Feb 19 21:47:24 2013 +0000
Initial version of `nativeCSSDetect()` - only accepts a string e.g. `'(flex-wrap:reverse)'`; would quite like to overload the interface
|
That's about the best I can squash it – for some reason it's showing some of Zoltan's commits which are already in master. |
stucox
pushed a commit
that referenced
this pull request
Aug 1, 2013
Use CSS.supports() internally (fixes #818)
This was referenced Aug 1, 2013
| * which case testAllProps will only return true if the browser supports that | ||
| * value for the named property; this latter case will use native detection | ||
| * (via window.CSS.supports) if available. A boolean can be passed as a 3rd | ||
| * parameter to |
There was a problem hiding this comment.
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Use CSS.supports() internally (fixes Modernizr#818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See original issue #818
Reviews welcome, although it's had a few on the
supportsbranch.API changes to
testProp()andtestAllProps()– draft documentation here.