Add a small regression test to -wrap-flow property testing #853
Conversation
|
Do we need this? Unless there's proof of a browser giving a false positive with the standard detect, we try to go for the simplest (and hence fastest) detect we can. |
|
if it IS necessary then lets document in the code why. Thanks for your help on this detect, @zhorvath |
|
Unfortunately, yes. We parse the property in WebKit, but we haven't got the implementation for the wrap-flow yet, so the original test case is false+ for WebKit. @paulirish: I'm going to add a comment to the code. |
|
@zhorvath how does CSS.supports() fair with |
|
@paulirish: sorry, I don't know what CSS.supports() is. Could you send me a pointer to it? |
|
It's only implemented in FirefoxAurora and Opera at the moment, neither of which support |
|
CSS.supports() is implemented in WebKit, but both Safari and Chromium hasn't enabled the build flag... |
|
So, do you like this pull request? :) |
|
Yep, cheers. I take it it's still |
|
Yes. I tested with the latest public IE10. |
Add a small regression test to -wrap-flow property testing
|
Nice one, thanks. LGTM. |
Add a small regression test to -wrap-flow property testing
We need to extend the wrap-flow testing with a small regression test to get the accurate result. Testing only the property parsing is not enough anymore.