-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Relative Units (vw, vh, vmin, vmax) - Re: Issue #572 #638
Conversation
Would these need to be in 4 separate tests? I would imagine a browser vendor would implement them all at the same time. They should probably be under one parent object like video or audio Modernizr.cssviewportlengths = {
vh: ...,
vw: ...
//etc
} |
Chrome 20 implements Would it be better if I put |
seems okay as four separate tests. gzip would wipe out the byte duplication. kinda nice to keep things atomic. |
getComputedStyle(elem, null) : | ||
elem.currentStyle)["height"],10); | ||
|
||
bool= !!(compStyle == height); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The !! Seems to be unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right. Removing them now.
lgtm. you, @ryanseddon ? |
@ryanseddon said:
I think if Modernizr has taught me anything, it’s not to trust browser vendors for sensible things like that. ;-) It looks good to me, merging. |
CSS Relative Units (vw, vh, vmin, vmax) - Re: Issue #572
CSS Relative Units (vw, vh, vmin, vmax) - Re: Issue Modernizr#572
Kindly review. =)
Re: #572