Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css-hyphens bugfix, cleanup, warning #563

Merged
merged 3 commits into from
May 11, 2012
Merged

css-hyphens bugfix, cleanup, warning #563

merged 3 commits into from
May 11, 2012

Conversation

nwtn
Copy link
Contributor

@nwtn nwtn commented Apr 19, 2012

Includes a bugfix for the softhyphensfind test, cleanup of two unused vars, and a warning about a Hyphenator.js bug.

nwtn added 3 commits April 19, 2012 15:23
<input> was being inserted below <div>, which was messing up focus and
causing false negatives in Chrome (at least)
Added link to Hyphenator.js issue that will cause problems when using
Modernizr.load.
@aFarkas
Copy link
Member

aFarkas commented Apr 20, 2012

Looks good to me. @nwtn, you can abuse Modernizr.testStyles(str,fn) to create a fakeBody, so that the test doesn't require to be added below the head. html5shiv is using this technique (https://github.com/aFarkas/html5shiv/blob/master/src/html5shiv.js#L27-34) (injectElementWithStyles == Modernizr.testStyles)

@nwtn
Copy link
Contributor Author

nwtn commented Apr 20, 2012

Thanks, I'll take a look. My instinct is that it won't work because of the browser-find stuff that happens, but I hope I'm wrong.

@nwtn
Copy link
Contributor Author

nwtn commented Apr 27, 2012

Unfortunately, I can't get browser-find working with Modernizr.testStyles. Firefox is giving Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIDOMWindow.find], even after a successful check for window.find. So, for now I think it'll have to stay like this.

I've noticed some other issues with how Opera is behaving, but that's a problem for another pull request.

@paulirish
Copy link
Member

thanks for the review and cleanup! :)

paulirish added a commit that referenced this pull request May 11, 2012
css-hyphens bugfix, cleanup, warning
@paulirish paulirish merged commit f4afeb6 into Modernizr:master May 11, 2012
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
css-hyphens bugfix, cleanup, warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants