Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added detection of type worker option and aspect ratio #2702

Merged
merged 7 commits into from
Oct 16, 2022
Merged

Added detection of type worker option and aspect ratio #2702

merged 7 commits into from
Oct 16, 2022

Conversation

debadutta98
Copy link
Contributor

@debadutta98 debadutta98 commented Sep 26, 2022 •
edited
Loading

Hi @rejas @stucox @patrickkettner,

  • Added two Feature
    Detect Aspect ratio CSS property
    Detect web worker type option

Closes #2694
Closes #2693

modernizr version-4.0.0-alpha
Node version:- v14.18.0
OS-window 11

Thank you, waiting for your response

@debadutta98
Copy link
Contributor Author

debadutta98 commented Oct 14, 2022 •
edited
Loading

Hi @rejas I just updated my solution and it's passed all test cases

Thank you! waiting for your response

@debadutta98 debadutta98 changed the title Added detection of workeroption and aspectratio css property Added detection of type worker option and aspect ratio Oct 14, 2022
@rejas rejas self-requested a review October 14, 2022 18:19
rejas
rejas requested changes Oct 14, 2022
View reviewed changes
Copy link
Member

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, at first glance looks not bad :) small cosmetic stuff, and please revert the changes to the package-lock.json file

@debadutta98
Copy link
Contributor Author

thx, at first glance looks not bad :) small cosmetic stuff, and please revert the changes to the package-lock.json file

@rejas Thank you for addressing the issue package-lock.json is successfully reverted at 4372a33

@rejas rejas merged commit 59ab0b3 into Modernizr:master Oct 16, 2022
@rejas
Copy link
Member

rejas commented Oct 16, 2022

Thx for the PR!

rejas pushed a commit that referenced this pull request Jul 20, 2023
Added detection of type worker option and aspect ratio (#2702)
a1f6189 
* added detection of workeroption and aspectratio css property

* update aspectration.js rename workeroptions.js to workertypeoption.js update config-all.json and caniuse.js and all testcase passed

* update caniuse

* revert package-lock.json file

* apply requested changes on both files
@rejas rejas mentioned this pull request Jul 20, 2023
Merged
rejas added a commit that referenced this pull request Jul 20, 2023
@rejas
Add latest feature detects and fixes from v4 branch (#2726)
d57b8ca 
* Fix: Update lowbandwidth condition to match new spec (#2688)

* Adds PushManager feature detection #2703 (#2708)

* Added detection of type worker option and aspect ratio (#2702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejas rejas rejas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECMAScript modules in workers About aspect-ratio CSS property
2 participants
@debadutta98 @rejas