Fix: Update lowbandwidth condition to match new spec #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [minimist](https://github.com/substack/minimist) and [minimist](https://github.com/substack/minimist). These dependencies needed to be updated together. Updates `minimist` from 1.2.6 to 1.2.6 - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.6...1.2.6) Updates `minimist` from 1.2.5 to 1.2.6 - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.6...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
Thx for the PR! |
rejas
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Update lowbandwidth condition to match new spec
rejas
added a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection spec has gone through mutiple updates but the lowbandwidth test still tests against the initial spec which introduced the preliminary version of the network information API. The newest version of the NetworkInformation API, which is still in draft (https://wicg.github.io/netinfo/#dfn-connection-type), has changed the name of the property being used to determine the quality of the network from
typetoeffectiveType. Kindly notetypenow provides a list of strings describing different network adapters (ie ethernet, bluetooth, wifi, e.t.c). This PR updates the check to account for the old and new properties.