Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gulp connect to listen on any IP addresses available #2677

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

heliocorreia
Copy link
Contributor

@heliocorreia heliocorreia commented Oct 16, 2021

Set gulp connect to listen on any IP addresses available, i.e., the gh-pages and browser tests can be accessed from localhost and virtual machines when pointing to the host IP address.

https://www.npmjs.com/package/gulp-connect#optionshost

@rejas
Copy link
Member

rejas commented Oct 18, 2021

thx for the PR, what problem would that sovle though?

@heliocorreia
Copy link
Contributor Author

It is impossible to reach the gulp connect server instance when using a browser from a virtual machine (integrations tests) because the default host is localhost/127.0.0.1.

@rejas
Copy link
Member

rejas commented Oct 19, 2021

Thx for the explanation! Merging it :-)

@rejas rejas merged commit 28d969e into Modernizr:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants