Fix Undefined identifier error in es6symbol in IE8
#2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyword 'for' in `Symbol.for` caused `Undefined identifier` error in IE8.
|
Thank you @toddwong !! Did you recheck to see if it worked in IE8 (if you didn't just check it on the console, don't bother building the library). It looks okay, although I admit that I would never had thought of that solution. |
|
Yes, I rechecked. I actually rebuilt the library. We rebuild Modernizer everytime the website is packed with a webpack plugin. @Markel |
|
Thx for the PR, will merge it in the v3 branch too and release a bugfix version monday. |
rejas
pushed a commit
that referenced
this pull request
Jan 16, 2021
Keyword 'for' in `Symbol.for` caused `Undefined identifier` error in IE8.
rejas
pushed a commit
that referenced
this pull request
Jan 18, 2021
Keyword 'for' in `Symbol.for` caused `Undefined identifier` error in IE8.
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword 'for' in
Symbol.forcausedUndefined identifiererror in IE8.Modernizr/feature-detects/es6/symbol.js
Line 23 in 3514072