Fix datachannel test breaking Modernizr on PS4 #2599
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2599 +/- ##
=======================================
Coverage 95.15% 95.15%
=======================================
Files 5 5
Lines 165 165
=======================================
Hits 157 157
Misses 8 8 Continue to review full report at Codecov.
|
| try { | ||
| var peerConnection = new PeerConnectionConstructor({}); | ||
| return 'createDataChannel' in peerConnection; | ||
| } catch (e) { |
There was a problem hiding this comment.
if it errors shouldnt it return false then since the test fails?
There was a problem hiding this comment.
No, because this is inside a loop. We don't want to return false if the first iteration fails, we want to try them all.
|
So, is this something that you need soonish or can it wait for an unknown amount of time until v4 is released? |
As of some hope I already implemented the changes to the v4 PR 346f0c7. But yeah, the v4 version release date is pretty much unknown |
|
Ah, no, worries, I created a custom build with my fix. Cheers 👍 |
On PS4 the following happens:
Screenshot:
Duplicate of #2221, but that PR has been open for 2 years and has conflicts.