-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill the documentation #2561
Fill the documentation #2561
Conversation
Also changed the header levels to accomodate the new title/purpose
This reverts commit 98005b1.
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
=======================================
Coverage 95.15% 95.15%
=======================================
Files 5 5
Lines 165 165
=======================================
Hits 157 157
Misses 8 8 Continue to review full report at Codecov.
|
I'll soon solve the conflicts |
Okay merge conflicts solved, still there is a broken link link with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. what do you think @patrickkettner ?
🤔 I was thinking about the testing section, maybe it would be a good idea to put the Moreover, the testing section would be duplicated if we merge this PR (check the README) |
Since @patrickkettner went dark again, I'd merge it even without his review. Or what do you say @MarkelFe ? |
Up to you @rejas I mean, I think that nothing is technically wrong, so suggestions and improvements (some even mentioned by me) can be added later down the road. But yeah, up to you 🙃 |
Adds these new sections to the HOW_TO_WRITE_FEATURE_DETECTS.md:
It also reorders some files to follow alphabetical order.