Add support for ShadowRoot DOM api feature detect #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalim
force-pushed
the
dom-shadowroot
branch
from
8984d58 to
06129e7
Compare
|
Thx for the PR. But it test for both the old and the newer ShadowDom Api. The first check is against the deprecated call: https://caniuse.com/#feat=mdn-api_element_createshadowroot |
pascalim
force-pushed
the
dom-shadowroot
branch
from
06129e7 to
8e2d3b9
Compare
|
Good eye, yep sounds good, updated PR with |
pascalim
force-pushed
the
dom-shadowroot
branch
from
8e2d3b9 to
357f68e
Compare
|
Tests are failing, did you notice? Please fix that first :-) |
pascalim
force-pushed
the
dom-shadowroot
branch
from
357f68e to
b4071d2
Compare
|
@rejas it's a case of me not reading the documentation first :p Ok refactored the tests and it seems to appease the test runners |
rejas
requested changes
Oct 5, 2019
…` and `shadowroot-legacy` Co-authored-by: Kevin Coyle <kevin.coyle@theuniprogroup.com>
pascalim
force-pushed
the
dom-shadowroot
branch
from
b4071d2 to
5a65fc0
Compare
|
PR updated with requested changes |
rejas
approved these changes
Oct 5, 2019
|
thx a lot! good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ShadowRoot DOM api feature detect through
shadowrootandshadowroot-legacytests