Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding feature detection for navigator.connection.effectiveType #2381

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Adding feature detection for navigator.connection.effectiveType #2381

merged 1 commit into from
Oct 20, 2018

Conversation

escodel
Copy link
Contributor

@escodel escodel commented Oct 17, 2018

Closes #2378

Required a workaround to detect navigator.connection or set it to a value if not present. Detects and returns true if value is not zero. Otherwise, returns false.

  • Chrome Version 69.0.3497.100 (result: true)
  • Firefox Version 62.0.2 (result: false)
  • Edge Version 17.17134 (result: false)

@rejas rejas merged commit e14a7ae into Modernizr:master Oct 20, 2018
@rejas
Copy link
Member

rejas commented Oct 20, 2018

Thx :-)

@rejas rejas added this to the Modernizr v3.7 milestone Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Modernizr v3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@escodel @rejas