Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move custom ESLint rule to no-restricted-syntax #2359

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Move custom ESLint rule to no-restricted-syntax #2359

merged 1 commit into from
Aug 6, 2018

Conversation

niksy
Copy link
Contributor

@niksy niksy commented Aug 2, 2018

rulePaths from ESLint Node API is only available when directly used, but if you have linter active in code editor, Modernizr custom rule doesn’t work since it’s not discoverable. .eslintrc currently doesn’t have support for rule options (open issue), but we can use no-restriced-syntax with AST selectors to have that rule applied universally.

Copy link
Member

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rejas rejas merged commit a5f00a6 into Modernizr:master Aug 6, 2018
@rejas rejas added this to the Modernizr v3.7 milestone Oct 28, 2018
@niksy niksy deleted the eslint-rule branch January 25, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants